apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilganeli <...@git.apache.org>
Subject [GitHub] apex-malhar pull request #316: High-level WindowedStream API (Review only)
Date Thu, 09 Jun 2016 19:44:17 GMT
Github user ilganeli commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/316#discussion_r66508497
  
    --- Diff: library/src/main/java/com/datatorrent/lib/window/Quantification.java ---
    @@ -0,0 +1,31 @@
    +package com.datatorrent.lib.window;
    +
    +/**
    + * Created by siyuan on 6/3/16.
    + */
    +public class Quantification
    +{
    +  public static interface Unit
    +  {
    +  }
    +
    +  public static enum CountableUnit implements Unit
    +  {
    +    TUPLE,
    +    KTUPLE,
    +    MTUPLE
    +  }
    +
    +  public static enum TimeUnit implements Unit
    --- End diff --
    
    Why are we defining our own TimeUnits instead of using something relatively standard like
JodaTime or Java TimeUnit class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message