apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gauravgopi123 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request #339: APEXCORE-466 #resolve improved loggin...
Date Fri, 03 Jun 2016 23:14:18 GMT
Github user gauravgopi123 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/339#discussion_r65788854
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/client/RecordingsAgent.java ---
    @@ -640,7 +640,7 @@ public JSONObject process(WebResource.Builder webResource, Class<JSONObject>
cla
               }
           );
         } catch (Exception ex) {
    -      LOG.error("Exception caught", ex);
    +      LOG.error("Cannot start recording: ", ex);
    --- End diff --
    
    @davidyan74 : Should logging be not done at same levels? I see here it is "error" and
earlier it is done at "warn" and also this will print stacktrace but log messages at 546 line
won't...
    
    Any reason for inconsistent log levels?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message