apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From siyuanh <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request #338: APEXCORE-463 : fixed condition to all...
Date Fri, 03 Jun 2016 05:41:13 GMT
Github user siyuanh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/338#discussion_r65658772
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java ---
    @@ -355,7 +356,8 @@ public int size()
         }
         Set<String> result = new TreeSet<>();
         for (TypeGraphVertex node : tgv.allInstantiableDescendants) {
    -      if ((isAncestor(InputOperator.class.getName(), node.typeName) || !getAllInputPorts(node).isEmpty()))
{
    +      if ((isAncestor(InputOperator.class.getName(), node.typeName) || isAncestor(Module.class.getName(),
node.typeName)
    --- End diff --
    
    Can you squash the commits, I'll merge afterwards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message