Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: ilganeli <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
Message-ID: <git-pr-297-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: [APEXCORE-146] Add ClonePartit...
Content-Type: text/plain
Date: Thu, 26 May 2016 19:42:19 +0000 (UTC)
archived-at: Thu, 26 May 2016 19:42:24 -0000

GitHub user ilganeli opened a pull request:

    https://github.com/apache/incubator-apex-malhar/pull/297

    [APEXCORE-146] Add ClonePartitioner

    **Note:** This is still marked as an Apex issue even though it should live in Malhar. Once the JIRA is updated I'll update title and reference. 
    
    * Created a Clone partitioner similar to the StatelessPartitioner that assigns all data to all partitions
    * Added a simple unit test suite to test scale up and scale down
    
    **Questions**
    Is there a good place/way to add a test to verify that data is partitioned appropriately? For example, the stateless partitioner assigns keys based on the nearest power of two - is that validated anywhere?
    
    How is the serialVersionUUID generated?
    
    Does the manual assignment of ports to PartitionKeys need to happen for each Partition? There is a comment in the Partition class that by default all data is sent to all partitions. However, digging into the implementation in depth doesn't show that behavior. Instead, it seems data is assigned based on the mask associated with each Partition. 
    
    This references: https://issues.apache.org/jira/browse/APEXCORE-146

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilganeli/incubator-apex-malhar APEXCORE-146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-malhar/pull/297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #297
    
----
commit 74f6fd5113a3d488015a9817790018dd63b5e8cb
Author: Ilya Ganelin <ilya.ganelin@capitalone.com>
Date:   2016-05-26T19:39:24Z

    Added a new partitioner that replicates data across all partitions by default.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---