Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
Date: Fri, 27 May 2016 00:01:23 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12970967.1463617548000.310651.1464307283511@Atlassian.JIRA>
In-Reply-To: <JIRA.12970967.1463617548000@Atlassian.JIRA>
References: <JIRA.12970967.1463617548000@Atlassian.JIRA> <JIRA.12970967.1463617548349@arcas>
Subject: [jira] [Commented] (APEXMALHAR-2096) Add blockThreshold parameter
 to FSInputModule
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 27 May 2016 00:01:27 -0000


    [ https://issues.apache.org/jira/browse/APEXMALHAR-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303211#comment-15303211 ] 

ASF GitHub Bot commented on APEXMALHAR-2096:
--------------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/287#discussion_r64840404
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileSplitter.java ---
    @@ -53,6 +53,7 @@
        * This is a threshold on the no. of blocks emitted per window. A lot of blocks emitted
        * per window can overwhelm the downstream operators. This setting helps to control that.
        */
    +  @NotNull
    --- End diff --
    
    It will because min constraint is 1. By default the field will be assigned 0. So the user will have to change the value.  Please don't change types 


> Add blockThreshold parameter to FSInputModule
> ---------------------------------------------
>
>                 Key: APEXMALHAR-2096
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2096
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
> FileSplitter is very fast, the downstream operators can't work at that speed, so we need to limit the speed with which fileSplitter works.
> One way to do is limit number of blocks emitted per window.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)