Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 327CA2004CA for ; Wed, 11 May 2016 09:16:54 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 309561602BF; Wed, 11 May 2016 07:16:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7A8441602BE for ; Wed, 11 May 2016 09:16:53 +0200 (CEST) Received: (qmail 49356 invoked by uid 500); 11 May 2016 07:16:52 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 49344 invoked by uid 99); 11 May 2016 07:16:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 07:16:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9FC461A02CC for ; Wed, 11 May 2016 07:16:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.298 X-Spam-Level: * X-Spam-Status: No, score=1.298 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=datatorrent-com.20150623.gappssmtp.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id VMUeA17pINOT for ; Wed, 11 May 2016 07:16:49 +0000 (UTC) Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id D65C45F297 for ; Wed, 11 May 2016 07:16:49 +0000 (UTC) Received: by mail-oi0-f43.google.com with SMTP id x201so53856213oif.3 for ; Wed, 11 May 2016 00:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datatorrent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=eIHQfdm9W2/Rc0sHR5SvmUVLsVRSAM/KkS3ct4kZl9g=; b=bltkp9F+Nj1DA+LO8xbtaE5lw556gsy7yB4tAVn/bLs9dBWDpEzwnCHKEyL/Opgmaa FmnbkcfhgowfqgU2rZOwZXA02gaP1bOaMfx7xJQ33mxziKEkDBIqM/A7OaD4GBmYMLDE HnhPVrxT+0a0OBa2p//Y7c/JYJWIGVoXNs8dg1h3SgFF3csmaYYZDvZ6puj7SaEkA6F7 ALbfSop2qXsrLNl3C5iJve+K/FoZ2Dri3NEYkOUnkkDo1sXe0tvYj4Ll5dsqeE/CaLks TEnhGwT7OIvp8un6uubYLmz9hHT0FGpq9P/rI1LZ+d7LjaWGNdF9LWoFh/z6g6I7pZMR 70Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=eIHQfdm9W2/Rc0sHR5SvmUVLsVRSAM/KkS3ct4kZl9g=; b=TfXIZFQYdj0BlCm9ecAj2uwJhvfLbk4xvYY9pEAOQrt7CukBUbLzJ6L0FimuhAwYgj eL9il1g2JMy6lFSR++XUVQ0WvZ/JGtYdmtPKBWAeafCwkJPpu9FFnUCiRUA0VUwi8Qio di5RQUO80FwkZXpNf4Dxv9q5m1tNvC+e06HAXYG5/3x8lXNywqnAMtotm1mA22x0Ej35 tSgMyGANBCvUQ6Lz7ZbZ2zXqUsKFT7COT4p5rWU7GyxbSwPhG4mYyTuP3A/dVSUqA7ZV HsHsBwzgXzXC0Rm+RE+EqiAtiePXVMR4C8l4M6Y52cJV+tcNRsin8BWplJHxoht8JdVp pZaA== X-Gm-Message-State: AOPr4FWLkZzw9MQNVpqx3z2Msy8KcsFp7zd21Bn0lzFphevZeE2XBmwxvDf9Yh2TBvRlcBcEAiTCWuDodxv18wJt MIME-Version: 1.0 X-Received: by 10.157.57.200 with SMTP id y66mr827472otb.169.1462951008770; Wed, 11 May 2016 00:16:48 -0700 (PDT) Received: by 10.202.172.15 with HTTP; Wed, 11 May 2016 00:16:48 -0700 (PDT) In-Reply-To: References: Date: Wed, 11 May 2016 00:16:48 -0700 Message-ID: Subject: Re: APEXMALHAR-2084 - Getters and setters for Kafka are not consistent for topics and clusters From: Thomas Weise To: dev@apex.incubator.apache.org Content-Type: multipart/alternative; boundary=001a1141ab6033da2905328bd3da archived-at: Wed, 11 May 2016 07:16:54 -0000 --001a1141ab6033da2905328bd3da Content-Type: text/plain; charset=UTF-8 What are the issues that you have observed? On Wed, May 11, 2016 at 12:08 AM, Bhupesh Chawda wrote: > Hi All, > > The fields in Kafka Input Operator in Malhar kafka project are of type > String array. However the getters and setters are not consistent and have a > return type and parameters of String type respectively. > This may cause issues in down stream systems and hence must be fixed. I > have created a JIRA to track this - > https://issues.apache.org/jira/browse/APEXMALHAR-2084 > > I am proposing that the types of these fields be made List instead > of String[ ]. Additionally also make the getters and setters accept > parameters and return data of the same type. > > Please let me know your thoughts on the same. > > Thanks > ~Bhupesh > --001a1141ab6033da2905328bd3da--