Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CAHvM9d3QO==RiyGs_MEda0Nz-4CXR1is1sK==yswcKyTVCeuPg@mail.gmail.com>
References: <CAHvM9d3QO==RiyGs_MEda0Nz-4CXR1is1sK==yswcKyTVCeuPg@mail.gmail.com>
Date: Wed, 11 May 2016 08:43:27 -0700
Message-ID: <CAJ484BgyrTnQVBUJ8s5tRsL_SzZZKZmZuATB7zmBO9ODfrrJLw@mail.gmail.com>
Subject: Re: APEXMALHAR-2084 - Getters and setters for Kafka are not
 consistent for topics and clusters
From: Munagala Ramanath <ram@datatorrent.com>
To: dev@apex.incubator.apache.org
Content-Type: multipart/alternative; boundary=047d7b5d43482259c1053292e7a0
archived-at: Wed, 11 May 2016 15:43:34 -0000

--047d7b5d43482259c1053292e7a0
Content-Type: text/plain; charset=UTF-8

Yes, making the accessor types match the field will avoid confusion, so +1.

We can add accessors like getTopicItem() and setTopicItem() for the
individual
elements if necessary.

Ram

On Wed, May 11, 2016 at 12:08 AM, Bhupesh Chawda <bhupesh@datatorrent.com>
wrote:

> Hi All,
>
> The fields in Kafka Input Operator in Malhar kafka project are of type
> String array. However the getters and setters are not consistent and have a
> return type and parameters of String type respectively.
> This may cause issues in down stream systems and hence must be fixed. I
> have created a JIRA to track this -
> https://issues.apache.org/jira/browse/APEXMALHAR-2084
>
> I am proposing that the types of these fields be made List<String> instead
> of String[ ]. Additionally also make the getters and setters accept
> parameters and return data of the same type.
>
> Please let me know your thoughts on the same.
>
> Thanks
> ~Bhupesh
>

--047d7b5d43482259c1053292e7a0--