Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CAHvM9d3kZ4PhKdpG+GxxVLN7-=Q3Gp9PZ2P2tCfdZ1-UronXbA@mail.gmail.com>
References: <CAHvM9d3QO==RiyGs_MEda0Nz-4CXR1is1sK==yswcKyTVCeuPg@mail.gmail.com>
 <CAKJfLDMdoNM-5XqjJbFwoL2c4uCS_p1L0zuxz1VoG=NFGsjemQ@mail.gmail.com> <CAHvM9d3kZ4PhKdpG+GxxVLN7-=Q3Gp9PZ2P2tCfdZ1-UronXbA@mail.gmail.com>
From: Sandeep Deshmukh <sandeep@datatorrent.com>
Date: Wed, 11 May 2016 13:57:58 +0530
Message-ID: <CAAMMvRnsUyGS6_AY2Nuaq5v6FZwi7CuaPKkFj1xrH0kngv4fRg@mail.gmail.com>
Subject: Re: APEXMALHAR-2084 - Getters and setters for Kafka are not
 consistent for topics and clusters
To: dev <dev@apex.incubator.apache.org>
Content-Type: multipart/alternative; boundary=001a114128e0e1b40c05328cd2ef
archived-at: Wed, 11 May 2016 08:28:24 -0000

--001a114128e0e1b40c05328cd2ef
Content-Type: text/plain; charset=UTF-8

+1. Agree with you Bhupesh. We need to have consistent behaviour across all
the operators.

As Kafka 0.9 project is still evolving, I don't see any backward
compatibility issues.

Regards,
Sandeep

On Wed, May 11, 2016 at 1:11 PM, Bhupesh Chawda <bhupesh@datatorrent.com>
wrote:

> Hi Thomas,
>
> In my application, I am trying to configure this operator using a user
> interface. The getters and setters for *topics* (for example) are as
> follows:
>
> String[] topics;
>
> public String getTopics()
> public void setTopics(String topics)
>
> This is not considered consistent behaviour by the UI tool and hence it
> either deems the operator invalid or does not allow setting this property
> for the operator. Such could be the case with other UI tools as well.
>
> Additionally it makes sense to have getters and setters for a property,
> accept the same data-type as the property and not make them arbitrarily
> complex.
>
> Thanks
> ~Bhupesh
>
>
> On Wed, May 11, 2016 at 12:16 AM, Thomas Weise <thomas@datatorrent.com>
> wrote:
>
> > What are the issues that you have observed?
> >
> >
> > On Wed, May 11, 2016 at 12:08 AM, Bhupesh Chawda <
> bhupesh@datatorrent.com>
> > wrote:
> >
> > > Hi All,
> > >
> > > The fields in Kafka Input Operator in Malhar kafka project are of type
> > > String array. However the getters and setters are not consistent and
> > have a
> > > return type and parameters of String type respectively.
> > > This may cause issues in down stream systems and hence must be fixed. I
> > > have created a JIRA to track this -
> > > https://issues.apache.org/jira/browse/APEXMALHAR-2084
> > >
> > > I am proposing that the types of these fields be made List<String>
> > instead
> > > of String[ ]. Additionally also make the getters and setters accept
> > > parameters and return data of the same type.
> > >
> > > Please let me know your thoughts on the same.
> > >
> > > Thanks
> > > ~Bhupesh
> > >
> >
>

--001a114128e0e1b40c05328cd2ef--