Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: chandnisingh <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-287-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-287-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2096: Add property ...
Content-Type: text/plain
Message-Id: <20160526234421.3DCCBDFBD6@git1-us-west.apache.org>
Date: Thu, 26 May 2016 23:44:21 +0000 (UTC)
archived-at: Thu, 26 May 2016 23:44:26 -0000

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/287#discussion_r64839243
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileSplitter.java ---
    @@ -53,6 +53,7 @@
        * This is a threshold on the no. of blocks emitted per window. A lot of blocks emitted
        * per window can overwhelm the downstream operators. This setting helps to control that.
        */
    +  @NotNull
    --- End diff --
    
    Please don't change the type.  Having the constraint min(1) is sufficient 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---