Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: ilooner <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-276-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-276-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2073 fixed the race...
Content-Type: text/plain
Message-Id: <20160517044757.616AFDFC92@git1-us-west.apache.org>
Date: Tue, 17 May 2016 04:47:57 +0000 (UTC)
archived-at: Tue, 17 May 2016 04:48:01 -0000

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/276#discussion_r63463982
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/managed/IncrementalCheckpointManager.java ---
    @@ -188,8 +190,12 @@ protected void committed(int operatorId, long windowId) throws IOException, Inte
       {
         LOG.debug("data manager committed {}", windowId);
         for (Long currentWindow : savedWindows.keySet()) {
    +      if (currentWindow <= smallestPendingWindow) {
    +        continue;
    +      }
           if (currentWindow <= windowId) {
    -        LOG.debug("to transfer {}", windowId);
    +        LOG.debug("to transfer {}", currentWindow);
    +        smallestPendingWindow = currentWindow;
    --- End diff --
    
    can the name be changed of smallestPendingWindow. It can be slightly misleading.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---