Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: vrozov <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-334-incubator-apex-core@git.apache.org>
In-Reply-To: <git-pr-334-incubator-apex-core@git.apache.org>
Subject: [GitHub] incubator-apex-core pull request: APEXCORE-458 Using the yarn conf...
Content-Type: text/plain
Message-Id: <20160517004210.61F90DFB73@git1-us-west.apache.org>
Date: Tue, 17 May 2016 00:42:10 +0000 (UTC)
archived-at: Tue, 17 May 2016 00:42:16 -0000

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/334#discussion_r63450055
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/client/StramClientUtils.java ---
    @@ -739,13 +745,21 @@ public static InetSocketAddress getRMWebAddress(Configuration conf, String rmId)
     
       public static InetSocketAddress getRMWebAddress(Configuration conf, boolean sslEnabled, String rmId)
       {
    -    rmId = (rmId == null) ? "" : ("." + rmId);
    +    boolean isHA = (rmId != null);
    +    rmId = isHA ? ("." + rmId) : "";
    +    if (isHA) {
    +      conf = getYarnConfiguration(conf);
    +      conf.set(ConfigUtils.RM_HA_ID, rmId);
    +    }
         InetSocketAddress address;
         if (sslEnabled) {
           address = conf.getSocketAddr(YarnConfiguration.RM_WEBAPP_HTTPS_ADDRESS + rmId, YarnConfiguration.DEFAULT_RM_WEBAPP_HTTPS_ADDRESS, YarnConfiguration.DEFAULT_RM_WEBAPP_HTTPS_PORT);
    --- End diff --
    
    rmId should not be appended to `YarnConfiguration.RM_WEBAPP_HTTPS_ADDRESS`. `YarnConfiguration.getSocketAddr()` will return value based on `RM_HA_ID`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---