Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chinmaykolhatkar <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-270-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-270-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2082 Data Filter Op...
Content-Type: text/plain
Message-Id: <20160514064046.C37B5DFA0C@git1-us-west.apache.org>
Date: Sat, 14 May 2016 06:40:46 +0000 (UTC)
archived-at: Sat, 14 May 2016 06:40:52 -0000

Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/270#discussion_r63272134
  
    --- Diff: library/src/main/java/com/datatorrent/lib/filter/FilterOperator.java ---
    @@ -0,0 +1,177 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package com.datatorrent.lib.filter;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import org.apache.hadoop.classification.InterfaceStability;
    +
    +import com.google.common.annotations.VisibleForTesting;
    +
    +import com.datatorrent.api.AutoMetric;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.Context.PortContext;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +
    +import com.datatorrent.api.Operator;
    +import com.datatorrent.api.annotation.InputPortFieldAnnotation;
    +import com.datatorrent.api.annotation.OutputPortFieldAnnotation;
    +
    +import com.datatorrent.common.util.BaseOperator;
    +import com.datatorrent.lib.expression.Expression;
    +import com.datatorrent.lib.util.PojoUtils;
    +
    +/**
    + * <b>FilterOperator</b>
    + * Filter Operator filter out tuples based on defined condition
    + *
    + * <b>Parameters</b>
    + * - condition: condition based on expression langugage
    + *
    + * <b>Input Port</b> takes POJOs as an input
    + *
    + * <b>Output Ports</b>
    + * - truePort emits POJOs meeting the given condition
    + * - falsePort emits POJOs not meeting the given condition
    + * - error port emits any error situation while evaluating expression
    + * 
    + */
    +@InterfaceStability.Evolving
    +public class FilterOperator extends BaseOperator implements Operator.ActivationListener
    +{
    +  protected String condition;
    +
    +  protected Class<?> inClazz = null;
    +
    +  private Expression<Boolean> expr = null;
    +
    +  @AutoMetric
    +  protected long trueTuples;
    +
    +  @AutoMetric
    +  protected long falseTuples;
    --- End diff --
    
    If its a anticipation under which these variables are made protected, I suggest to make them private now and later on need basis change the access modifier.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---