Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: amberarrow <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-273-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-273-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2077 AbstractSingle...
Content-Type: text/plain
Message-Id: <20160513180729.1344FDFADE@git1-us-west.apache.org>
Date: Fri, 13 May 2016 18:07:29 +0000 (UTC)
archived-at: Fri, 13 May 2016 18:07:33 -0000

Github user amberarrow commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/273#discussion_r63226693
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractSingleFileOutputOperator.java ---
    @@ -39,10 +41,37 @@
       @NotNull
       protected String outputFileName;
     
    +  /**
    +   * partitionedFileName string format specifier 
    +      e.g. fileName_physicalPartionId -> %s_%d 
    +   */
    +  private String partitionedFileNameformat = "%s_%d";
    +
    +  /**
    +   * Derived name for file based on physicalPartitionId
    +   */
    +  private transient String partitionedFileName;
    +
    +  /**
    +   * Physical partition id for the current partition.
    +   */
    +  private transient int physicalPartitionId;
    +
    +  /**
    +   * Initializing current partition id, partitionedFileName etc. {@inheritDoc}
    +   */
    +  @Override
    +  public void setup(OperatorContext context)
    --- End diff --
    
    Ok. Can we at least provide a way to turn off this behavior -- e.g. if the format string is null or the empty string, the operatorId is not appended.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---