Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: amberarrow <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-273-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-273-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2077 AbstractSingle...
Content-Type: text/plain
Message-Id: <20160513144029.A6DE5DFDE3@git1-us-west.apache.org>
Date: Fri, 13 May 2016 14:40:29 +0000 (UTC)
archived-at: Fri, 13 May 2016 14:40:40 -0000

Github user amberarrow commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/273#discussion_r63194215
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractSingleFileOutputOperator.java ---
    @@ -52,6 +81,7 @@ protected String getFileName(INPUT tuple)
       public void setOutputFileName(String outputFileName)
       {
         this.outputFileName = outputFileName;
    +    partitionedFileName = String.format(partitionedFileNameformat, outputFileName, physicalPartitionId);
    --- End diff --
    
    Since partitionedFileName is assigned in setup() there is no need to do it here; in fact, since these setters are typically called before the operator is serialized, physicalPartitionId will always be 0 here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---