Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 067AE2004CA for ; Wed, 11 May 2016 09:18:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0484E160A13; Wed, 11 May 2016 07:18:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4C9A61602BE for ; Wed, 11 May 2016 09:18:16 +0200 (CEST) Received: (qmail 50772 invoked by uid 500); 11 May 2016 07:18:15 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 50760 invoked by uid 99); 11 May 2016 07:18:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 07:18:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DD856C1790 for ; Wed, 11 May 2016 07:18:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.436 X-Spam-Level: X-Spam-Status: No, score=-5.436 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.416] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id T42pIWlG34Oj for ; Wed, 11 May 2016 07:18:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 451F25F24B for ; Wed, 11 May 2016 07:18:13 +0000 (UTC) Received: (qmail 50616 invoked by uid 99); 11 May 2016 07:18:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 07:18:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5C12BDFD43; Wed, 11 May 2016 07:18:12 +0000 (UTC) From: bhupeshchawda To: dev@apex.incubator.apache.org Reply-To: dev@apex.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1953 Updated Jdbc O... Content-Type: text/plain Message-Id: <20160511071812.5C12BDFD43@git1-us-west.apache.org> Date: Wed, 11 May 2016 07:18:12 +0000 (UTC) archived-at: Wed, 11 May 2016 07:18:17 -0000 Github user bhupeshchawda commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/215#discussion_r62801341 --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPOJOOutputOperator.java --- @@ -63,22 +58,18 @@ * @since 2.1.0 */ @org.apache.hadoop.classification.InterfaceStability.Evolving -public class JdbcPOJOOutputOperator extends AbstractJdbcTransactionableOutputOperator - implements Operator.ActivationListener +public abstract class AbstractJdbcPOJOOutputOperator extends AbstractJdbcTransactionableOutputOperator { - @NotNull - private List fieldInfos; + private List fieldInfos; --- End diff -- We can call it SqlFieldInfo. I think JdbcFieldInfo is also appropriate right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---