Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chandnisingh <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-267-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-267-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2081 removed HDFS s...
Content-Type: text/plain
Message-Id: <20160509210133.6841CDFDE3@git1-us-west.apache.org>
Date: Mon,  9 May 2016 21:01:33 +0000 (UTC)
archived-at: Mon, 09 May 2016 21:01:39 -0000

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/267#discussion_r62572337
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -266,6 +266,7 @@ public TimeBasedDirectoryScanner getScanner()
       public static class TimeBasedDirectoryScanner implements Runnable, Component<Context.OperatorContext>
       {
         private static long DEF_SCAN_INTERVAL_MILLIS = 5000;
    +    private static String FILE_BEING_COPIED = "_COPYING_";
    --- End diff --
    
    
    1. Ignore regex is a property that is a property is set by the user so it can be changed by the user anytime.
    IMO this is a clean/explicit way of doing it.  
    
    2. That is correct. However it is highly unlikely that on other file systems, the  actual files are called something that ends with _COPYING_. If its important I will make this run for only HDFS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---