apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2084) Getters and setters for Kafka are not consistent for topics and clusters
Date Tue, 17 May 2016 16:44:12 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15286977#comment-15286977
] 

ASF GitHub Bot commented on APEXMALHAR-2084:
--------------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/275#discussion_r63558782
  
    --- Diff: kafka/src/main/java/org/apache/apex/malhar/kafka/AbstractKafkaInputOperator.java
---
    @@ -413,33 +413,39 @@ public int getInitialPartitionCount()
         return initialPartitionCount;
       }
     
    -  public void setClusters(String clusters)
    -  {
    -    this.clusters = clusters.split(";");
    -  }
    -
       /**
        *  Same setting as bootstrap.servers property to KafkaConsumer
        *  refer to http://kafka.apache.org/documentation.html#newconsumerconfigs
    -   *  To support multi cluster, you can have multiple bootstrap.servers separated by
";"
    +   *  To support multi cluster, you can have multiple elements in the array
        */
    -  public String getClusters()
    +  public void setClusters(String[] clusters)
       {
    -    return Joiner.on(';').join(clusters);
    +    this.clusters = clusters;
    --- End diff --
    
    Have you tested it? If so, would it make sense to include it into the javadoc? 
    
    @siyuanh does this address the issue you were trying to fix previously?



> Getters and setters for Kafka are not consistent for topics and clusters
> ------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2084
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2084
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Bhupesh Chawda
>            Assignee: Bhupesh Chawda
>
> The getters and setters in Kafka input operator in Malhar-kafka for the fields: topics
and clusters are not consistent and may cause problems in down stream systems.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message