apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-451) get-app-package-operators in ApexCLI to contain "type" property to indicate operator or module
Date Thu, 05 May 2016 23:58:13 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273339#comment-15273339
] 

ASF GitHub Bot commented on APEXCORE-451:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/326#discussion_r62273672
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java ---
    @@ -348,13 +348,13 @@ public int size()
     
       public Set<String> getAllDTInstantiableOperators()
       {
    -    TypeGraphVertex tgv = typeGraph.get(Operator.class.getName());
    +    TypeGraphVertex tgv = typeGraph.get(DAG.GenericOperator.class.getName());
         if (tgv == null) {
           return null;
         }
         Set<String> result = new TreeSet<>();
         for (TypeGraphVertex node : tgv.allInstantiableDescendants) {
    -      if ((isAncestor(InputOperator.class.getName(), node.typeName) || !getAllInputPorts(node).isEmpty()))
{
    +      if ((isAncestor(DAG.GenericOperator.class.getName(), node.typeName) || !getAllInputPorts(node).isEmpty()))
{
    --- End diff --
    
    That's right, it was either input operator or at least one input port.


> get-app-package-operators in ApexCLI to contain "type" property to indicate operator
or  module
> -----------------------------------------------------------------------------------------------
>
>                 Key: APEXCORE-451
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-451
>             Project: Apache Apex Core
>          Issue Type: New Feature
>            Reporter: shubham pathak
>            Assignee: shubham pathak
>
> Apex apps  can contain both operators and modules. We would need an additional property
in the response of  get-app-package-operators  to distinguish between the two.
> We can  have a "type" property that will be enum of values
> e.g. "type" : "operator" to indicate operator
>        "type" : "composite" to indicate a module



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message