apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2081) Remove FSFileSplitter, BlockReader, HDFSFileSplitter, HDFSInputModule
Date Mon, 09 May 2016 20:37:13 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276986#comment-15276986
] 

ASF GitHub Bot commented on APEXMALHAR-2081:
--------------------------------------------

Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/267#discussion_r62568407
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/block/BlockReader.java ---
    @@ -1,66 +0,0 @@
    -/**
    - * Licensed to the Apache Software Foundation (ASF) under one
    - * or more contributor license agreements.  See the NOTICE file
    - * distributed with this work for additional information
    - * regarding copyright ownership.  The ASF licenses this file
    - * to you under the Apache License, Version 2.0 (the
    - * "License"); you may not use this file except in compliance
    - * with the License.  You may obtain a copy of the License at
    - *
    - *   http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing,
    - * software distributed under the License is distributed on an
    - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    - * KIND, either express or implied.  See the License for the
    - * specific language governing permissions and limitations
    - * under the License.
    - */
    -package com.datatorrent.lib.io.block;
    -
    -import java.io.IOException;
    -import java.net.URI;
    -
    -import org.apache.hadoop.fs.FileSystem;
    -
    -import com.datatorrent.api.AutoMetric;
    -
    -/**
    - * BlockReader extends {@link FSSliceReader} to accept case insensitive uri
    - */
    -public class BlockReader extends FSSliceReader
    -{
    -  @AutoMetric
    --- End diff --
    
    shouldn't we move the metrics to parent class?


> Remove FSFileSplitter, BlockReader, HDFSFileSplitter, HDFSInputModule
> ---------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2081
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2081
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>          Components: adapters other
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>            Priority: Critical
>             Fix For: 3.4.0
>
>
> Recently there was an FSFileSplitter added to the library.
> This operator adds 2 additional properties which can be added to the base operator.
> A problem with this approach of adding new extension which just add small features is
that it confuses the users of which Operator to use and essentially we have multiple operators
with the same basic functionality.
> This should be done before the new version of Malhar is released.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message