apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2078) Potential thread issue in FileSplitterInput class
Date Tue, 17 May 2016 00:36:12 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285730#comment-15285730
] 

ASF GitHub Bot commented on APEXMALHAR-2078:
--------------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/268#discussion_r63449581
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -194,7 +194,12 @@ protected boolean processFileInfo(FileInfo fileInfo)
     
       protected void updateReferenceTimes(ScannedFileInfo fileInfo)
       {
    -    referenceTimes.put(fileInfo.getFilePath(), fileInfo.modifiedTime);
    +    Map<String, Long> referenceTimeMap;
    --- End diff --
    
    Nitpicking: please call the local variable ```referenceTimePerInputDir```. Will help to
remember why it was changed.


> Potential thread issue in FileSplitterInput class
> -------------------------------------------------
>
>                 Key: APEXMALHAR-2078
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2078
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>             Fix For: 3.4.0
>
>
> The "inputDirTolastModifiedTimes" field is modified by multiple threads and check pointed
by operator thread. This could cause threading issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message