apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2045) Add bandwidth control feature to Apex
Date Wed, 18 May 2016 21:20:12 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289843#comment-15289843
] 

ASF GitHub Bot commented on APEXMALHAR-2045:
--------------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/279#discussion_r63784273
  
    --- Diff: library/src/main/java/com/datatorrent/lib/bandwidth/BandwidthManager.java ---
    @@ -0,0 +1,137 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.lib.bandwidth;
    +
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.ScheduledExecutorService;
    +import java.util.concurrent.TimeUnit;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import com.datatorrent.api.Component;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.Context.OperatorContext;
    +
    +/**
    + * BandwidthManager keeps track of bandwidth consumption and provides limit on maximum
bandwidth that can be consumed at
    + * any moment. This accumulates bandwidth upto certain limits so that accumulated bandwidth
can be used over a period of
    + * time.
    + */
    +public class BandwidthManager implements Component<Context.OperatorContext>
    +{
    +  private static final Logger LOG = LoggerFactory.getLogger(BandwidthManager.class);
    +  /**
    +   * Maximum bandwidth that can be consumed in bytes/sec
    +   */
    +  private long bandwidthLimit = Long.MAX_VALUE;
    +  private transient long currentBandwidthConsumption;
    +  private final transient ScheduledExecutorService scheduler;
    +  private final transient Object lock = new Object();
    +
    +  public BandwidthManager()
    +  {
    +    scheduler = Executors.newScheduledThreadPool(1);
    +  }
    +
    +  BandwidthManager(ScheduledExecutorService scheduler)
    +  {
    +    this.scheduler = scheduler;
    +  }
    +
    +  @Override
    +  public void setup(OperatorContext context)
    +  {
    +    scheduler.scheduleAtFixedRate(new BandwidthAccumulator(), 1, 1, TimeUnit.SECONDS);
    +  }
    +
    +  public boolean canConsumeBandwidth()
    +  {
    +    if (!isBandwidthRestricted()) {
    +      return true;
    +    }
    +    synchronized (lock) {
    +      if (currentBandwidthConsumption >= 0) {
    +        return true;
    +      }
    +    }
    +    return false;
    +  }
    +
    +  public void consumeBandwidth(long sentTupleSize)
    +  {
    +    if (isBandwidthRestricted()) {
    +      synchronized (lock) {
    +        currentBandwidthConsumption -= sentTupleSize;
    +      }
    +    }
    +  }
    +
    +  public boolean isBandwidthRestricted()
    +  {
    +    if (bandwidthLimit == Long.MAX_VALUE) {
    +      return false;
    +    }
    +    return true;
    +  }
    +
    +  /**
    +   * get maximum bandwidth that can be consumed in bytes/sec
    +   *
    +   * @return
    +   */
    +  public long getBandwidth()
    +  {
    +    return bandwidthLimit;
    +  }
    +
    +  /**
    +   * Set maximum bandwidth that can be consumed in bytes/sec
    +   *
    +   * @param bandwidth
    +   */
    +  public void setBandwidth(long bandwidth)
    +  {
    +    this.bandwidthLimit = bandwidth;
    +    LOG.info("Bandwidth limit is set to: " + bandwidth + " bytes/sec");
    +  }
    +
    +  @Override
    +  public void teardown()
    +  {
    +    scheduler.shutdownNow();
    +  }
    +
    +  class BandwidthAccumulator implements Runnable
    +  {
    +    @Override
    +    public void run()
    +    {
    +      if (isBandwidthRestricted()) {
    +        synchronized (lock) {
    +          if (currentBandwidthConsumption < 0) {
    --- End diff --
    
    This condition does not seem to be correct. Should not currentBandwidthConsumption be
set to the limit when this method is invoked independently of how much bandwidth were consumed
during the previous period?


> Add bandwidth control feature to Apex
> -------------------------------------
>
>                 Key: APEXMALHAR-2045
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2045
>             Project: Apache Apex Malhar
>          Issue Type: Task
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
>  bandwidth restrictions on input operator for number of bytes to be consumed per second.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message