apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-330) Ability to obtain a thread dump from a container
Date Mon, 02 May 2016 18:11:13 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267143#comment-15267143
] 

ASF GitHub Bot commented on APEXCORE-330:
-----------------------------------------

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/321#discussion_r61777791
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/util/StackTrace.java ---
    @@ -0,0 +1,77 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.stram.util;
    +
    +import java.util.Map;
    +
    +import org.codehaus.jettison.json.JSONArray;
    +import org.codehaus.jettison.json.JSONException;
    +import org.codehaus.jettison.json.JSONObject;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class StackTrace
    +{
    +  private static final Logger LOG = LoggerFactory.getLogger(StackTrace.class);
    +
    +  public static String getJsonFormat()
    +  {
    +    Map<Thread, StackTraceElement[]> stackTraces = Thread.getAllStackTraces();
    +
    +    JSONObject jsonObject = new JSONObject();
    +    JSONArray jsonArray = new JSONArray();
    +
    +    int j = 0;
    +    for (Map.Entry<Thread,StackTraceElement[]> elements : stackTraces.entrySet())
{
    +
    +      JSONObject jsonThreads = new JSONObject();
    +
    +      Thread thread = elements.getKey();
    +
    +      try {
    +
    +        jsonThreads.put("Name", thread.getName());
    +        jsonThreads.put("State", thread.getState());
    +        jsonThreads.put("ID", thread.getId());
    +
    +        JSONArray stacks = new JSONArray();
    +
    +        for (int i = 0; i < elements.getValue().length; ++i) {
    +
    +          stacks.put(i, elements.getValue()[i].toString());
    +        }
    +
    +        jsonThreads.put("Stacks", stacks);
    +
    +        jsonArray.put(j++, jsonThreads);
    --- End diff --
    
    We should just use jsonArray(jsonThreads) without the counter `j`


> Ability to obtain a thread dump from a container
> ------------------------------------------------
>
>                 Key: APEXCORE-330
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-330
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Thomas Weise
>            Assignee: Sandesh
>
> To analyze issues such as "stuck operator", it is useful to obtain stats from the running
JVM. Often needed are GC stats and thread dump. In production environments users often don't
have direct access to the machines, making it available through the REST API will help.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message