apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Munagala Ramanath <...@datatorrent.com>
Subject Re: APEXMALHAR-2084 - Getters and setters for Kafka are not consistent for topics and clusters
Date Wed, 11 May 2016 15:43:27 GMT
Yes, making the accessor types match the field will avoid confusion, so +1.

We can add accessors like getTopicItem() and setTopicItem() for the
elements if necessary.


On Wed, May 11, 2016 at 12:08 AM, Bhupesh Chawda <bhupesh@datatorrent.com>

> Hi All,
> The fields in Kafka Input Operator in Malhar kafka project are of type
> String array. However the getters and setters are not consistent and have a
> return type and parameters of String type respectively.
> This may cause issues in down stream systems and hence must be fixed. I
> have created a JIRA to track this -
> https://issues.apache.org/jira/browse/APEXMALHAR-2084
> I am proposing that the types of these fields be made List<String> instead
> of String[ ]. Additionally also make the getters and setters accept
> parameters and return data of the same type.
> Please let me know your thoughts on the same.
> Thanks
> ~Bhupesh

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message