apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chaithu14 <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2103 Fixed the scan...
Date Mon, 30 May 2016 05:00:44 GMT
Github user chaithu14 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/300#discussion_r65023539
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -375,11 +374,11 @@ public void run()
                 lastScannedInfo = null;
                 numDiscoveredPerIteration = 0;
                 for (String afile : files) {
    -              String filePath = new File(afile).getAbsolutePath();
    -              LOG.debug("Scan started for input {}", filePath);
    +              Path filePath = new Path(afile);
    +              LOG.debug("Scan started for input {}", filePath.toString());
                   Map<String, Long> lastModifiedTimesForInputDir;
    -              lastModifiedTimesForInputDir = referenceTimes.get(filePath);
    -              scan(new Path(afile), null, lastModifiedTimesForInputDir);
    +              lastModifiedTimesForInputDir = referenceTimes.get(fs.getFileStatus(filePath).getPath().toString());
    --- End diff --
    
    No. In case of LocalFileSystem, if the filePath consists of relative path then again the
keys are different. 
    Setting the directory path in createScannedFileInfo() and accessing the value from referenceTimes
must be sync.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message