apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2096: Add property ...
Date Thu, 26 May 2016 23:59:37 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/287#discussion_r64840404
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractFileSplitter.java ---
    @@ -53,6 +53,7 @@
        * This is a threshold on the no. of blocks emitted per window. A lot of blocks emitted
        * per window can overwhelm the downstream operators. This setting helps to control
that.
        */
    +  @NotNull
    --- End diff --
    
    It will because min constraint is 1. By default the field will be assigned 0. So the user
will have to change the value.  Please don't change types 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message