apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2006 Stream API
Date Thu, 19 May 2016 22:49:56 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/261#discussion_r63966880
  
    --- Diff: library/src/main/java/com/datatorrent/lib/algo/UniqueCounter.java ---
    @@ -78,10 +78,10 @@ public void process(K tuple)
       /**
        * The output port which emits a map from keys to the number of times they occurred
within an application window.
        */
    -  public final transient DefaultOutputPort<HashMap<K, Integer>> count = new
DefaultOutputPort<HashMap<K, Integer>>()
    +  public final transient DefaultOutputPort<Map<K, Integer>> count = new DefaultOutputPort<Map<K,
Integer>>()
    --- End diff --
    
    Why this change? The output port should declare the specific type. Unlike the input port,
which should be least restrictive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message