apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2078: Thread issue ...
Date Tue, 17 May 2016 00:35:31 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/268#discussion_r63449581
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -194,7 +194,12 @@ protected boolean processFileInfo(FileInfo fileInfo)
     
       protected void updateReferenceTimes(ScannedFileInfo fileInfo)
       {
    -    referenceTimes.put(fileInfo.getFilePath(), fileInfo.modifiedTime);
    +    Map<String, Long> referenceTimeMap;
    --- End diff --
    
    Nitpicking: please call the local variable ```referenceTimePerInputDir```. Will help to
remember why it was changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message