apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davidyan74 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-458 Using the yarn conf...
Date Mon, 16 May 2016 23:33:53 GMT
Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/334#discussion_r63443931
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/client/StramClientUtils.java ---
    @@ -739,13 +745,21 @@ public static InetSocketAddress getRMWebAddress(Configuration conf,
String rmId)
     
       public static InetSocketAddress getRMWebAddress(Configuration conf, boolean sslEnabled,
String rmId)
       {
    -    rmId = (rmId == null) ? "" : ("." + rmId);
    +    boolean isHA = (rmId != null);
    +    rmId = isHA ? ("." + rmId) : "";
    +    if (isHA) {
    +      conf = getYarnConfiguration(conf);
    +      conf.set(ConfigUtils.RM_HA_ID, rmId);
    +    }
         InetSocketAddress address;
         if (sslEnabled) {
           address = conf.getSocketAddr(YarnConfiguration.RM_WEBAPP_HTTPS_ADDRESS + rmId,
YarnConfiguration.DEFAULT_RM_WEBAPP_HTTPS_ADDRESS, YarnConfiguration.DEFAULT_RM_WEBAPP_HTTPS_PORT);
         } else {
           address = conf.getSocketAddr(YarnConfiguration.RM_WEBAPP_ADDRESS + rmId, YarnConfiguration.DEFAULT_RM_WEBAPP_ADDRESS,
YarnConfiguration.DEFAULT_RM_WEBAPP_PORT);
         }
    +    if (isHA) {
    +      conf.unset(ConfigUtils.RM_HA_ID);
    +    }
         LOG.info("rm webapp address setting {}", address);
    --- End diff --
    
    the conf.set and conf.unset combo may not have the expected behavior if getRMWebAddress()
is called by multiple threads at the same time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message