apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amberarrow <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2077 AbstractSingle...
Date Mon, 16 May 2016 23:33:42 GMT
Github user amberarrow commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/273#discussion_r63443902
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/AbstractSingleFileOutputOperator.java
---
    @@ -39,10 +41,37 @@
       @NotNull
       protected String outputFileName;
     
    +  /**
    +   * partitionedFileName string format specifier 
    +      e.g. fileName_physicalPartionId -> %s_%d 
    +   */
    +  private String partitionedFileNameformat = "%s_%d";
    +
    +  /**
    +   * Derived name for file based on physicalPartitionId
    +   */
    +  private transient String partitionedFileName;
    +
    +  /**
    +   * Physical partition id for the current partition.
    +   */
    +  private transient int physicalPartitionId;
    +
    +  /**
    +   * Initializing current partition id, partitionedFileName etc. {@inheritDoc}
    +   */
    +  @Override
    +  public void setup(OperatorContext context)
    --- End diff --
    
    Yogi, if you can just implement the check if the format string is null or empty, we can
merge this.  We can defer the issue of whether dynamically changing the file name is supported
for the next release. We have no guarantee on the value of the operator id (not guaranteed
to start at 0).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message