apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhupeshchawda <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1953 Updated Jdbc O...
Date Wed, 11 May 2016 07:18:12 GMT
Github user bhupeshchawda commented on a diff in the pull request:

    --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPOJOOutputOperator.java
    @@ -63,22 +58,18 @@
      * @since 2.1.0
    -public class JdbcPOJOOutputOperator extends AbstractJdbcTransactionableOutputOperator<Object>
    -    implements Operator.ActivationListener<OperatorContext>
    +public abstract class AbstractJdbcPOJOOutputOperator extends AbstractJdbcTransactionableOutputOperator<Object>
    -  @NotNull
    -  private List<FieldInfo> fieldInfos;
    +  private List<JdbcFieldInfo> fieldInfos;
    --- End diff --
    We can call it SqlFieldInfo.
    I think JdbcFieldInfo is also appropriate right? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message