apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DT-Priyanka <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2081 removed HDFS s...
Date Mon, 09 May 2016 20:39:45 GMT
Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/267#discussion_r62568807
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/fs/FileSplitterInput.java ---
    @@ -266,6 +266,7 @@ public TimeBasedDirectoryScanner getScanner()
       public static class TimeBasedDirectoryScanner implements Runnable, Component<Context.OperatorContext>
       {
         private static long DEF_SCAN_INTERVAL_MILLIS = 5000;
    +    private static String FILE_BEING_COPIED = "_COPYING_";
    --- End diff --
    
    Couple of questions:
    1. Why do we have it as independent field and then check it as extension? We can put it
as default in ignore regex part right?
    2. This is generic class applicable to file systems other than HDFS, it is safe to ignore
these files on other file systems? This file may not mean same on other file systems.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message