apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shubham-pathak22 <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-451 : get-app-package-o...
Date Fri, 06 May 2016 05:47:15 GMT
Github user shubham-pathak22 commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/326#discussion_r62290758
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/webapp/TypeGraph.java ---
    @@ -348,13 +348,13 @@ public int size()
     
       public Set<String> getAllDTInstantiableOperators()
       {
    -    TypeGraphVertex tgv = typeGraph.get(Operator.class.getName());
    +    TypeGraphVertex tgv = typeGraph.get(DAG.GenericOperator.class.getName());
         if (tgv == null) {
           return null;
         }
         Set<String> result = new TreeSet<>();
         for (TypeGraphVertex node : tgv.allInstantiableDescendants) {
    -      if ((isAncestor(InputOperator.class.getName(), node.typeName) || !getAllInputPorts(node).isEmpty()))
{
    +      if ((isAncestor(DAG.GenericOperator.class.getName(), node.typeName) || !getAllInputPorts(node).isEmpty()))
{
    --- End diff --
    
    You are right. This is not needed. I assumed getAllDTInstantiableOperators() was where
all operators are loaded into the result set . Will revert it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message