apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vrozov <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-402
Date Tue, 03 May 2016 00:59:31 GMT
Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/286#discussion_r61828415
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/AbstractReservoir.java ---
    @@ -47,7 +49,7 @@
     {
       private static final Logger logger = LoggerFactory.getLogger(AbstractReservoir.class);
       static final String reservoirClassNameProperty = "com.datatorrent.stram.engine.Reservoir";
    -  private static final int USE_SPSC_CAPACITY = 8 * 1024;
    +  private static final int USE_SPSC_CAPACITY = 64 * 1024;
    --- End diff --
    
    As SpscArrayBlockingQueueReservoir provides larger throughtput compared to ArrayBlockingQueueReservoir,
it exceeds throughput of SpscReservoir for larger queue capacity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message