apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-107 Support for adding ...
Date Mon, 02 May 2016 09:01:16 GMT
Github user tushargosavi commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/313#discussion_r61717221
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/plan/logical/LogicalPlan.java ---
    @@ -239,7 +239,7 @@ public void sendMetrics(Collection<String> metricNames)
       {
         @SuppressWarnings("FieldNameHidesFieldInSuperclass")
         private static final long serialVersionUID = 1L;
    -    private OperatorMeta operatorMeta;
    +    private DagNodeMeta operatorMeta;
    --- End diff --
    
    The port can belong to Operator or Module. hence used a common meta object in the portmeta.
This common meta object contains only
    - ports 
    - name
    - object
    
    The rest of Operator specific fields are in OperatorMeta and Module specific fields are
in ModuleMeta.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message