Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CCFD419D27 for ; Fri, 15 Apr 2016 14:41:36 +0000 (UTC) Received: (qmail 87791 invoked by uid 500); 15 Apr 2016 14:41:36 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 87719 invoked by uid 500); 15 Apr 2016 14:41:36 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 87708 invoked by uid 99); 15 Apr 2016 14:41:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 14:41:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id AB43CC10D0 for ; Fri, 15 Apr 2016 14:41:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.016 X-Spam-Level: X-Spam-Status: No, score=-5.016 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.996] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id s5NB5yaWrLtu for ; Fri, 15 Apr 2016 14:41:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 1AC035F396 for ; Fri, 15 Apr 2016 14:41:33 +0000 (UTC) Received: (qmail 87698 invoked by uid 99); 15 Apr 2016 14:41:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 14:41:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2D3F6DFBA0; Fri, 15 Apr 2016 14:41:33 +0000 (UTC) From: vrozov To: dev@apex.incubator.apache.org Reply-To: dev@apex.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-apex-core pull request: APEXCORE-422 reverted the change... Content-Type: text/plain Message-Id: <20160415144133.2D3F6DFBA0@git1-us-west.apache.org> Date: Fri, 15 Apr 2016 14:41:33 +0000 (UTC) Github user vrozov commented on the pull request: https://github.com/apache/incubator-apex-core/pull/309#issuecomment-210487635 @tweise I would suggest to merge it before 3.4.0 goes out. Currently checkstyle definition xml is out of sync with the apex-codestyle-config-1.0.0-incubating.jar published to maven. PR fixes inconsistency by reverting back the change in checkstyle definition. The second change can wait, but it is not clear what is the cons of not pulling it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---