Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3443E192F4 for ; Tue, 5 Apr 2016 00:28:14 +0000 (UTC) Received: (qmail 58368 invoked by uid 500); 5 Apr 2016 00:28:14 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 58291 invoked by uid 500); 5 Apr 2016 00:28:14 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 58274 invoked by uid 99); 5 Apr 2016 00:28:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 00:28:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 73CEF180225 for ; Tue, 5 Apr 2016 00:28:13 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id VTtLMrqoMnkj for ; Tue, 5 Apr 2016 00:28:12 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id 554A75F20E for ; Tue, 5 Apr 2016 00:28:12 +0000 (UTC) Received: (qmail 58262 invoked by uid 99); 5 Apr 2016 00:28:11 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 00:28:11 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 83B28DFC6E; Tue, 5 Apr 2016 00:28:11 +0000 (UTC) From: ilooner To: dev@apex.incubator.apache.org Reply-To: dev@apex.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-apex-core pull request: APEXCORE-415 #resolve #comment F... Content-Type: text/plain Message-Id: <20160405002811.83B28DFC6E@git1-us-west.apache.org> Date: Tue, 5 Apr 2016 00:28:11 +0000 (UTC) Github user ilooner commented on the pull request: https://github.com/apache/incubator-apex-core/pull/292#issuecomment-205558086 @PramodSSImmaneni @davidyan74 I have added tests. @davidyan74 I don't think your suggestion would work because it does not account for the ProcessMode and doCheckpoint variable interactions. I would like to maintain the same pattern for handling this corner case as existed previously in order to avoid unintended bugs. The code can be refactored down the road after more tests and documentation are introduced. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---