apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2043) Update checkstyle plugin declaration to use apex-codestyle-config artifact
Date Tue, 05 Apr 2016 04:41:25 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225677#comment-15225677
] 

ASF GitHub Bot commented on APEXMALHAR-2043:
--------------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/231#discussion_r58486048
  
    --- Diff: library/pom.xml ---
    @@ -35,6 +35,7 @@
       <name>Apache Apex Malhar (incubating) Library</name>
     
       <properties>
    +    <checkstyle.console>false</checkstyle.console>
    --- End diff --
    
    This is how it is in Apex core as well by @vrozov so was mimicking it.
    I think the reason is that by default we don't want to print all the existing violations
to console so we set the user property ```checkstyle.console``` to ```false```. However we
give the user the option to see the existing violations by ```mvn checkstyle:check -Dcheckstyle.console```
 if they want to see the existing violations.
    
    If ```logViolationsToConsole``` is set to false, then user will not be able to spit out
violations to the console.


> Update checkstyle plugin declaration to use apex-codestyle-config artifact
> --------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2043
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2043
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>             Fix For: 3.4.0
>
>
> We have created apex-codestyle-config which externalizes checkstyle configurations.
> Malhar has a copy of apex_checks.xml and checkstyle-suppressions.xml. These can be removed
by adding dependency to apex-codestyle-config in the checkstyle plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message