apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-413) Collision between Sink.getCount() and SweepableReservoir.getCount()
Date Mon, 11 Apr 2016 20:41:25 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235947#comment-15235947
] 

ASF GitHub Bot commented on APEXCORE-413:
-----------------------------------------

GitHub user vrozov opened a pull request:

    https://github.com/apache/incubator-apex-core/pull/301

    APEXCORE-413 - Collision between Sink.getCount() and SweepableReservoir.getCount()

    @tweise Please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vrozov/incubator-apex-core APEXCORE-413

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-apex-core/pull/301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #301
    
----
commit 8168b617a6bc2c232bf4063a8f212231646d7953
Author: Vlad Rozov <v.rozov@datatorrent.com>
Date:   2016-04-01T03:41:05Z

    APEXCORE-413 - Collision between Sink.getCount() and SweepableReservoir.getCount()

----


> Collision between Sink.getCount() and SweepableReservoir.getCount()
> -------------------------------------------------------------------
>
>                 Key: APEXCORE-413
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-413
>             Project: Apache Apex Core
>          Issue Type: Bug
>    Affects Versions: 3.2.0, 3.3.0
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>             Fix For: 3.4.0
>
>
> SweepableReservoir.getCount() and Sink.getCount() are two distinct counts as SweepableReservoir.getCount()
returns number of tuples consumed/poll from the reservoir by an operator since the last reset,
while Sink.getCount() returns number of tuples pushed into the sink since the last reset.
For InlineStream that implements both interfaces, it causes a conflict as a count of tuples
pushed into InlineStream is not necessarily equal to a count of tuples poll from it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message