apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-401) Create a separate artifact for checkstyle and other common configurations
Date Fri, 01 Apr 2016 19:25:25 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222208#comment-15222208
] 

ASF GitHub Bot commented on APEXCORE-401:
-----------------------------------------

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/290#discussion_r58255053
  
    --- Diff: pom.xml ---
    @@ -335,6 +336,11 @@
               <version>2.17</version>
               <dependencies>
                 <dependency>
    +              <groupId>org.apache.apex</groupId>
    +              <artifactId>apex-codestyle-config</artifactId>
    +              <version>${project.version}</version>
    --- End diff --
    
    I am not sure of this but can we not change this to a fixed previously released version?


> Create a separate artifact for checkstyle and other common configurations
> -------------------------------------------------------------------------
>
>                 Key: APEXCORE-401
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-401
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>
> As of now, Apex Core and Apex Malhar have same checkstyle rules. These rules are present
in a file called apex_checks.xml. There are separate copies of these present in both the repositories.
Any change to the configuration has to be made manually at multiple places. 
> We can improve this by creating another artifact which includes such common configuration
and Apex Malhar can reference it directly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message