apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-401) Create a separate artifact for checkstyle and other common configurations
Date Fri, 01 Apr 2016 18:42:25 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222146#comment-15222146

ASF GitHub Bot commented on APEXCORE-401:

Github user vrozov commented on a diff in the pull request:

    --- Diff: pom.xml ---
    @@ -335,6 +336,11 @@
    +              <groupId>org.apache.apex</groupId>
    +              <artifactId>apex-codestyle-config</artifactId>
    +              <version>${project.version}</version>
    --- End diff --
    This is a dependency on SNAPSHOT version that will be propagated to Malhar library. IMO,
codestyle artifact should be on a different release cycle compared to Apex and/or Malhar and
this is where separating it into a separate project will help. This will also help with avoiding
every developer rebuilding the artifact every time Apex is built.

> Create a separate artifact for checkstyle and other common configurations
> -------------------------------------------------------------------------
>                 Key: APEXCORE-401
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-401
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
> As of now, Apex Core and Apex Malhar have same checkstyle rules. These rules are present
in a file called apex_checks.xml. There are separate copies of these present in both the repositories.
Any change to the configuration has to be made manually at multiple places. 
> We can improve this by creating another artifact which includes such common configuration
and Apex Malhar can reference it directly.

This message was sent by Atlassian JIRA

View raw message