apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-304) Ability to add jars to classpath in populateDAG
Date Mon, 18 Apr 2016 18:49:25 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246307#comment-15246307
] 

ASF GitHub Bot commented on APEXCORE-304:
-----------------------------------------

Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/311#discussion_r60113016
  
    --- Diff: api/src/main/java/com/datatorrent/api/StreamingApplication.java ---
    @@ -47,6 +47,12 @@
       String ENVIRONMENT = DT_PREFIX + "environment";
     
       /**
    +   * Use this config variable to to add any external library to classpath for the DAG.
    +   * Value of this variable is same as StramAppLauncher.LIBJARS_CONF_KEY_NAME.
    +   */
    +  String LIBJARS_CONF_KEY_NAME = "tmplibjars";
    --- End diff --
    
    Just looking at the string literal suggests something isn't right here. We configure applications
through attributes, not random properties in the config file. Can you please check if there
is a better way to express this dependency.


> Ability to add jars to classpath in populateDAG
> -----------------------------------------------
>
>                 Key: APEXCORE-304
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-304
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chinmay Kolhatkar
>            Assignee: Chinmay Kolhatkar
>
> This will have following functionality:
> 1) In populateDAG one would be allowed to add given local jar path to classpath of the
application.
> 2) Optionally delete the given jar file after copying to HDFS is done.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message