apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Farkas <...@datatorrent.com>
Subject Re: Checkstyle import order needs to accomodate org.apache.apex
Date Wed, 06 Apr 2016 19:31:42 GMT
+1 for David's suggestion except for the blank lines.

On Wed, Apr 6, 2016 at 11:30 AM, Chandni Singh <chandni@datatorrent.com>
wrote:

> Except the blanks lines I agree with David.
>
> It is future proof to have everything in lexicographic order.
>
> Will still like to have blank lines.
> Chandni
>
> On Wed, Apr 6, 2016 at 12:24 PM, David Yan <david@datatorrent.com> wrote:
>
> > I think the import order should be alphabetical or lexicographical, and
> no
> > blank lines are needed.
> >
> > The reason is this:
> >
> > 1) It's simple and future proof, and there will be no need to have this
> > discussion again in the future about what order it should be and where
> the
> > blank lines should be placed
> > 2) It's easy to follow, and there is no rule to remember other than it's
> > alphabetical
> > 3) It's easy to find where a particular import lines are because it's
> > alphabetical
> >
> > Whatever we come up with, we should make the change ASAP and fix all the
> > style violations once and for all.
> >
> > David
> >
> >
> > On Tue, Apr 5, 2016 at 5:12 PM, Chandni Singh <chandni@datatorrent.com>
> > wrote:
> >
> > > Hi,
> > >
> > > We need to include org.apache.apex in the import order that we have
> right
> > > now:
> > >
> > > *Current order:*
> > > java
> > > javax
> > > org
> > > org.apache
> > > io
> > > com
> > > com.datatorrent
> > > *
> > > all static imports
> > >
> > > *Proposed order:*
> > > java
> > > javax
> > > org
> > > org.apache
> > > io
> > > com
> > > com.datatorrent
> > > org.apache.apex
> > > *
> > > all static imports
> > >
> > > Thanks,
> > > Chandni
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message