apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chandnisingh <...@git.apache.org>
Subject [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2042 #resolve #comm...
Date Fri, 08 Apr 2016 00:13:11 GMT
Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/237#discussion_r58965285
  
    --- Diff: library/src/test/java/org/apache/apex/malhar/lib/state/managed/ManagedStateImplTest.java
---
    @@ -147,9 +150,11 @@ public void testCommitted()
         Slice two = ManagedStateTestUtils.getSliceFor("2");
         commitHelper(one, two);
         Bucket.DefaultBucket defaultBucket = (Bucket.DefaultBucket)testMeta.managedState.getBucket(0);
    -    Assert.assertEquals("value of one", one, defaultBucket.getCommittedData().get(one).getValue());
    +    Assert.assertEquals("value of one",
    +        one, defaultBucket.getCommittedData().firstEntry().getValue().get(one).getValue());
    --- End diff --
    
    this is less 120 lines. please don't break it into 2 lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message