apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-10 #resolve Changes for...
Date Thu, 07 Apr 2016 18:19:31 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/250#discussion_r58919720
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/StreamingAppMasterService.java ---
    @@ -750,6 +752,11 @@ private void execute() throws YarnException, IOException
             expiryTime = StramUserLogin.refreshTokens(tokenLifeTime, FileUtils.getTempDirectoryPath(),
applicationId, conf, hdfsKeyTabFile, credentials, rmAddress, true);
           }
     
    +      if (System.currentTimeMillis() > nodeReportUpdateTime) {
    --- End diff --
    
    Still see System.currentTimeMillis repeated within the loop. Please make a final variable
out of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message