apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] incubator-apex-core pull request: APEXCORE-411 support restarting ...
Date Tue, 05 Apr 2016 03:35:18 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-core/pull/294#discussion_r58482768
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/cli/DTCli.java ---
    @@ -1861,49 +1862,60 @@ public void execute(String[] args, ConsoleReader reader) throws
Exception
             } catch (Exception ex) {
               throw new CliException("Error opening the config XML file: " + configFile,
ex);
             }
    -        String fileName = expandFileName(commandLineInfo.args[0], true);
             StramAppLauncher submitApp;
             AppFactory appFactory = null;
    -        String matchString = commandLineInfo.args.length >= 2 ? commandLineInfo.args[1]
: null;
    -        if (fileName.endsWith(".json")) {
    -          File file = new File(fileName);
    -          submitApp = new StramAppLauncher(file.getName(), config);
    -          appFactory = new StramAppLauncher.JsonFileAppFactory(file);
    -          if (matchString != null) {
    -            LOG.warn("Match string \"{}\" is ignored for launching applications specified
in JSON", matchString);
    -          }
    -        } else if (fileName.endsWith(".properties")) {
    -          File file = new File(fileName);
    -          submitApp = new StramAppLauncher(file.getName(), config);
    -          appFactory = new StramAppLauncher.PropertyFileAppFactory(file);
    -          if (matchString != null) {
    -            LOG.warn("Match string \"{}\" is ignored for launching applications specified
in properties file", matchString);
    +        String matchString = null;
    +        if (commandLineInfo.args.length == 0) {
    +          if (commandLineInfo.origAppId == null) {
    +            throw new CliException("APA or JAR file is required for launching an application
when not recovering from a terminated application");
    --- End diff --
    
    "when not resuming terminated application" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message