Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 281FA19386 for ; Thu, 17 Mar 2016 00:46:37 +0000 (UTC) Received: (qmail 66830 invoked by uid 500); 17 Mar 2016 00:46:36 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 66754 invoked by uid 500); 17 Mar 2016 00:46:36 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 66742 invoked by uid 99); 17 Mar 2016 00:46:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 00:46:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5A0F11A0511 for ; Thu, 17 Mar 2016 00:46:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -3.549 X-Spam-Level: X-Spam-Status: No, score=-3.549 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bl9SzRrp32Rf for ; Thu, 17 Mar 2016 00:46:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 873E75F3F0 for ; Thu, 17 Mar 2016 00:46:34 +0000 (UTC) Received: (qmail 66734 invoked by uid 99); 17 Mar 2016 00:46:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 00:46:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 760652C14FB for ; Thu, 17 Mar 2016 00:46:33 +0000 (UTC) Date: Thu, 17 Mar 2016 00:46:33 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXCORE-380) Idle time sleep time should increase from 0 to a configurable max value MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/APEXCORE-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198496#comment-15198496 ] ASF GitHub Bot commented on APEXCORE-380: ----------------------------------------- Github user PramodSSImmaneni commented on a diff in the pull request: https://github.com/apache/incubator-apex-core/pull/271#discussion_r56440964 --- Diff: engine/src/main/java/com/datatorrent/stram/engine/GenericNode.java --- @@ -608,9 +610,9 @@ else if (tracker.ports[trackerIndex] == null) { if (need2sleep) { if (handleIdleTime && insideWindow) { ((IdleTimeHandler) operator).handleIdleTime(); - } - else { + } else { Thread.sleep(spinMillis); + spinMillis = Math.min(maxSpinMillis, spinMillis + 1); --- End diff -- I had looked at this before in a difference scenario. Can we do a better heuristic. We can have another timeout setting (which is less than streaming window size) where we continue to do busy way till that timeout and if there is no data till then, then initiate the stepwise sleep. > Idle time sleep time should increase from 0 to a configurable max value > ----------------------------------------------------------------------- > > Key: APEXCORE-380 > URL: https://issues.apache.org/jira/browse/APEXCORE-380 > Project: Apache Apex Core > Issue Type: Improvement > Affects Versions: 3.4.0 > Reporter: Vlad Rozov > Assignee: Vlad Rozov > Fix For: 3.4.0 > > > When all active input ports of an operator are empty, the operator either calls idle time handler or goes into a wait. In the later case, the wait time should start with 0 and increase to the configured/default idle spin time to handle cases when there is trickle and pour stream of tuples. -- This message was sent by Atlassian JIRA (v6.3.4#6332)