Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
Date: Mon, 14 Mar 2016 10:11:33 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.12926028.1450226753000.6359.1457950293633@Atlassian.JIRA>
In-Reply-To: <JIRA.12926028.1450226753000@Atlassian.JIRA>
References: <JIRA.12926028.1450226753000@Atlassian.JIRA>
 <JIRA.12926028.1450226753000@arcas>
Subject: [jira] [Commented] (APEXMALHAR-1948) CassandraStore Should Allow
 You To Specify Protocol Version.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/APEXMALHAR-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193028#comment-15193028 ] 

ASF GitHub Bot commented on APEXMALHAR-1948:
--------------------------------------------

Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/188#discussion_r55978278
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/cassandra/CassandraStore.java ---
    @@ -115,21 +130,35 @@ public Session getSession() {
       /**
        * Creates a cluster object.
        */
    -  public void buildCluster(){
    -
    +  public void buildCluster()
    +  {
         try {
    -
    -      cluster = Cluster.builder()
    -          .addContactPoint(node).withCredentials(userName, password).build();
    -    }
    -    catch (DriverException ex) {
    +      if (protocolVersion != null && protocolVersion.length() != 0) {
    +        ProtocolVersion version = getCassandraProtocolVersion();
    +        cluster = Cluster.builder().addContactPoint(node).withCredentials(userName, password).withProtocolVersion(version).build();
    +      } else {
    --- End diff --
    
    which version does it use in the default case? Should we add a specific default? Like for example, the latest version?


> CassandraStore Should Allow You To Specify Protocol Version.
> ------------------------------------------------------------
>
>                 Key: APEXMALHAR-1948
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1948
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Priyanka Gugale
>
> When working on an app I noticed that the default protocol version used when connecting to cassandra was not the protocol version configured by the database. This leads to mysterious exceptions when connecting to cassandra. The protocol should be configurable via a user property.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)