Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chinmaykolhatkar <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-211-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-211-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2011-2012
 Avro to P...
Content-Type: text/plain
Message-Id: <20160330072439.58773DFF10@git1-us-west.apache.org>
Date: Wed, 30 Mar 2016 07:24:39 +0000 (UTC)

Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/211#discussion_r57846153
  
    --- Diff: contrib/src/main/java/com/datatorrent/contrib/avro/PojoToAvro.java ---
    @@ -0,0 +1,264 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package com.datatorrent.contrib.avro;
    +
    +import java.io.IOException;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import org.apache.avro.AvroRuntimeException;
    +import org.apache.avro.Schema;
    +import org.apache.avro.Schema.Field;
    +import org.apache.avro.generic.GenericData;
    +import org.apache.avro.generic.GenericRecord;
    +import org.apache.commons.lang3.ClassUtils;
    +import org.apache.hadoop.classification.InterfaceStability;
    +
    +import com.datatorrent.api.AutoMetric;
    +import com.datatorrent.api.Context;
    +import com.datatorrent.api.Context.PortContext;
    +import com.datatorrent.api.DefaultInputPort;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.annotation.InputPortFieldAnnotation;
    +import com.datatorrent.common.util.BaseOperator;
    +import com.datatorrent.lib.util.PojoUtils;
    +import com.datatorrent.lib.util.PojoUtils.Getter;
    +
    +/**
    + * <p>
    + * PojoToAvro
    + * </p>
    + * A generic implementation for POJO to Avro conversion. A POJO is converted to
    + * a GenericRecord based on the schema provided. As of now only primitive types
    + * are supported.
    + *
    + * @displayName Pojo To Avro
    + * @category Converter
    + * @tags avro
    + * @since 3.3.0
    + */
    +@InterfaceStability.Evolving
    +public class PojoToAvro extends BaseOperator
    +{
    +
    +  private List<Field> columnNames;
    +
    +  private Class<?> cls;
    +
    +  private List<Getter> keyMethodMap;
    +
    +  private transient String schemaString;
    +
    +  private transient Schema schema;
    +
    +  @AutoMetric
    +  int recordCnt = 0;
    +
    +  @AutoMetric
    +  int errorCnt = 0;
    +
    +  @AutoMetric
    +  int fieldErrorCnt = 0;
    +
    +  public final transient DefaultOutputPort<GenericRecord> output = new DefaultOutputPort<GenericRecord>();
    +
    +  private void parseSchema() throws IOException
    +  {
    +    setSchema(new Schema.Parser().parse(getSchemaString()));
    +  }
    +
    +  /**
    +   * Returns the schema string for Avro Generic Record
    +   * 
    +   * @return schemaString
    +   */
    +  public String getSchemaString()
    +  {
    +    return schemaString;
    +  }
    +
    +  /**
    +   * Sets the schema string
    +   */
    +  public void setSchemaString(String schemaString)
    +  {
    +    this.schemaString = schemaString;
    +  }
    +
    +  /**
    +   * Returns the schema object
    +   * 
    +   * @return schema
    +   */
    +  private Schema getSchema()
    +  {
    +    return schema;
    +  }
    +
    +  /**
    +   * Sets the shcema object
    +   */
    +  private void setSchema(Schema schema)
    +  {
    +    this.schema = schema;
    +  }
    +
    +  /**
    +   * Returns the list for field names from provided Avro schema
    +   * 
    +   * @return List of Fields
    +   */
    +  private List<Field> getColumnNames()
    +  {
    +    return columnNames;
    +  }
    +
    +  /**
    +   * Sets the list of column names representing the fields in Avro schema
    +   */
    +  private void setColumnNames(List<Field> columnNames)
    +  {
    +    this.columnNames = columnNames;
    +  }
    +
    +  /**
    +   * This method generates the getters for provided field of a given class
    +   * 
    +   * @return Getter
    +   */
    +  private Getter<?, ?> generateGettersForField(Class<?> cls, String inputFieldName)
    +      throws NoSuchFieldException, SecurityException
    +  {
    +    java.lang.reflect.Field f = cls.getDeclaredField(inputFieldName);
    +    Class<?> c = ClassUtils.primitiveToWrapper(f.getType());
    +
    +    Getter<?, ?> classGetter = PojoUtils.createGetter(cls, inputFieldName, c);
    +
    +    return classGetter;
    +  }
    +
    +  /**
    +   * Initializes the list of columns in POJO based on the names from schema
    +   */
    +  private void initializeColumnMap(Schema schema)
    +  {
    +    setColumnNames(schema.getFields());
    +
    +    keyMethodMap = new ArrayList<Getter>();
    +    for (int i = 0; i < getColumnNames().size(); i++) {
    +      try {
    +        keyMethodMap.add(generateGettersForField(cls, getColumnNames().get(i).name()));
    +      } catch (NoSuchFieldException | SecurityException e) {
    +        throw new RuntimeException("Failed to initialize pojo class getters for field: ", e);
    +      }
    +    }
    +  }
    +
    +  @InputPortFieldAnnotation(optional = false, schemaRequired = true)
    +  public final transient DefaultInputPort<Object> data = new DefaultInputPort<Object>()
    +  {
    +
    +    @Override
    +    public void setup(PortContext context)
    +    {
    +      cls = context.getValue(Context.PortContext.TUPLE_CLASS);
    +
    +      try {
    +        parseSchema();
    +        initializeColumnMap(getSchema());
    +      } catch (IOException e) {
    +        LOG.error("Exception in parsing schema -" + e.getMessage());
    +      }
    +    }
    +
    +    @Override
    +    public void process(Object tuple)
    +    {
    +      processTuple(tuple);
    +    }
    +
    +  };
    +
    +  /**
    +   * Converts incoming tuples into Generic records
    +   */
    +  protected void processTuple(Object tuple)
    +  {
    +    GenericRecord record = null;
    +
    +    try {
    +      record = getGenericRecord(tuple);
    +    } catch (Exception e) {
    +      LOG.error("Exception in parsing record");
    +      errorCnt++;
    +    }
    +
    +    if (record != null) {
    +      output.emit(record);
    +      recordCnt++;
    +    } else {
    +      errorCnt++;
    --- End diff --
    
    If conversion fails, shouldn't this be going to error output port?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---