Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.incubator.apache.org
From: chandnisingh <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-204-incubator-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-204-incubator-apex-malhar@git.apache.org>
Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-1965 Utility
 classe...
Content-Type: text/plain
Message-Id: <20160329211800.0E2EFDFE1B@git1-us-west.apache.org>
Date: Tue, 29 Mar 2016 21:18:00 +0000 (UTC)

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/incubator-apex-malhar/pull/204#discussion_r57802416
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/wal/FSWal.java ---
    @@ -0,0 +1,178 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.apex.malhar.lib.wal;
    +
    +import java.io.DataInputStream;
    +import java.io.DataOutputStream;
    +import java.io.EOFException;
    +import java.io.IOException;
    +
    +import org.apache.hadoop.fs.FSDataOutputStream;
    +
    +import com.google.common.base.Preconditions;
    +
    +import com.datatorrent.lib.fileaccess.FileAccess;
    +
    +/**
    + * WAL implementation which allows writing entries to single file.
    + * the pointer type is the offset in the file. The entry is serialized into byte array and
    + * first length of the entry is written followed by the serialized bytes.
    + * @param <T>
    + */
    +public class FSWal<T> implements WAL<T, Long>
    +{
    +  transient long bucketKey;
    +  private transient String name;
    +  private transient FileAccess fa;
    +  private transient WAL.Serde<T> serde;
    +
    +  public FSWal(FileAccess fa, WAL.Serde<T> serde, long bucketKey, String name)
    --- End diff --
    
    I agree with Isha on using simple File API.
    I don't think there should be a bucket key here. IMO I was thinking of a WAL interface where you provide a path of the WAL and it automatically create part files as and when a file is complete (configured by size)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---