Return-Path: X-Original-To: apmail-apex-dev-archive@minotaur.apache.org Delivered-To: apmail-apex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BBF51928E for ; Thu, 10 Mar 2016 11:37:32 +0000 (UTC) Received: (qmail 12047 invoked by uid 500); 10 Mar 2016 11:37:31 -0000 Delivered-To: apmail-apex-dev-archive@apex.apache.org Received: (qmail 11985 invoked by uid 500); 10 Mar 2016 11:37:31 -0000 Mailing-List: contact dev-help@apex.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.incubator.apache.org Delivered-To: mailing list dev@apex.incubator.apache.org Received: (qmail 11974 invoked by uid 99); 10 Mar 2016 11:37:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2016 11:37:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 389F718053B for ; Thu, 10 Mar 2016 11:37:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.349 X-Spam-Level: X-Spam-Status: No, score=-4.349 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id t1MNf92nFaus for ; Thu, 10 Mar 2016 11:37:29 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id 544BD5F572 for ; Thu, 10 Mar 2016 11:37:28 +0000 (UTC) Received: (qmail 11971 invoked by uid 99); 10 Mar 2016 11:37:27 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2016 11:37:27 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id F3CB7DFBDE; Thu, 10 Mar 2016 11:37:26 +0000 (UTC) From: chinmaykolhatkar To: dev@apex.incubator.apache.org Reply-To: dev@apex.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-apex-malhar pull request: APEXMALHAR-2008: Create HDFS F... Content-Type: text/plain Message-Id: <20160310113726.F3CB7DFBDE@git1-us-west.apache.org> Date: Thu, 10 Mar 2016 11:37:26 +0000 (UTC) Github user chinmaykolhatkar commented on a diff in the pull request: https://github.com/apache/incubator-apex-malhar/pull/207#discussion_r55667219 --- Diff: library/src/test/java/com/datatorrent/lib/io/fs/FileSplitterInputTest.java --- @@ -110,8 +110,7 @@ protected void starting(org.junit.runner.Description description) fileSplitterInput.setIdempotentStorageManager(new IdempotentStorageManager.NoopIdempotentStorageManager()); Attribute.AttributeMap.DefaultAttributeMap attributes = new Attribute.AttributeMap.DefaultAttributeMap(); - attributes.put(Context.DAGContext.APPLICATION_PATH, - "target/" + className + "/" + methodName + "/" + Long.toHexString(System.currentTimeMillis())); + attributes.put(Context.DAGContext.APPLICATION_PATH, "target/" + className + "/" + methodName + "/" + Long.toHexString(System.currentTimeMillis())); --- End diff -- That's very wierd considering no code gets into master without rat check AFAIK. So without these changes does checkstyle validation fails? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---